fix: service.ranking must be an Integer to take effect#1409
Merged
sebthom merged 1 commit intoeclipse-lsp4e:mainfrom Nov 20, 2025
Merged
fix: service.ranking must be an Integer to take effect#1409sebthom merged 1 commit intoeclipse-lsp4e:mainfrom
service.ranking must be an Integer to take effect#1409sebthom merged 1 commit intoeclipse-lsp4e:mainfrom
Conversation
Contributor
|
bump version number? |
FlorianKroiss
force-pushed
the
service-ranking-integer
branch
from
92cc1dd to
0f625a9
Compare
sebthom
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately my previous fix #1363 was faulty, because
service.rankingmust be specified as an Integer or it won't take effect.The unit test in #1363 couldn't detect this, because services are sorted by service.ranking descending and then load order ascending and
DefaultFormatRegionsProvideris probably always loaded first in our test setup. My local testing also did not reveal this, because the load order just happened to be correct 😞To make sure this fix is now correct, I debugged the lookup in
ServiceRegistry.getServiceReference(BundleContextImpl, String)to make sure theservice.rankingofDefaultFormatRegionsProvideris correctly set to 1